Skip to content

Commit 008167d

Browse files
author
Calin Juravle
committed
Fix jsr166 tests
Tests specified as static inner classes were failing because the CTS runner does not support them. The temporary fix is to promote all static inner test classes to top level classes. This should be reverted once the CTS runner is fixed. Bug: 13877168 Change-Id: Icb64d7d7fcf6202d54d6fe31d9e1c9a6a43a233b
1 parent 6b3592a commit 008167d

17 files changed

+211
-73
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.ArrayBlockingQueue;
12+
import java.util.concurrent.BlockingQueue;
13+
14+
// In the upstream sources this class was nested inside ArrayBlockingQueueTests.
15+
// It was extracted to the top level because the CTS runner does not support
16+
// nested test classes. The same transformation was applied to all similar
17+
// classes from the jsr166 suite (see the parent CL for the complete list). This
18+
// should be reverted after CTS runner is fixed.
19+
public class ArrayBlockingQueueFairTest extends BlockingQueueTest {
20+
21+
protected BlockingQueue emptyCollection() {
22+
return new ArrayBlockingQueue(SIZE, true);
23+
}
24+
25+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.ArrayBlockingQueue;
12+
import java.util.concurrent.BlockingQueue;
13+
14+
public class ArrayBlockingQueueNotFairTest extends BlockingQueueTest {
15+
16+
protected BlockingQueue emptyCollection() {
17+
return new ArrayBlockingQueue(SIZE, false);
18+
}
19+
20+
}

jsr166-tests/src/test/java/jsr166/ArrayBlockingQueueTest.java

-12
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,6 @@
2424

2525
public class ArrayBlockingQueueTest extends JSR166TestCase {
2626

27-
public static class Fair extends BlockingQueueTest {
28-
protected BlockingQueue emptyCollection() {
29-
return new ArrayBlockingQueue(SIZE, true);
30-
}
31-
}
32-
33-
public static class NonFair extends BlockingQueueTest {
34-
protected BlockingQueue emptyCollection() {
35-
return new ArrayBlockingQueue(SIZE, false);
36-
}
37-
}
38-
3927
/**
4028
* Returns a new queue of given size containing consecutive
4129
* Integers 0 ... n.

jsr166-tests/src/test/java/jsr166/DelayQueueTest.java

+7-8
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,14 @@
2222
import java.util.concurrent.TimeUnit;
2323
import static java.util.concurrent.TimeUnit.MILLISECONDS;
2424

25-
public class DelayQueueTest extends JSR166TestCase {
25+
public class DelayQueueTest extends BlockingQueueTest {
2626

27-
public static class Generic extends BlockingQueueTest {
28-
protected BlockingQueue emptyCollection() {
29-
return new DelayQueue();
30-
}
31-
protected PDelay makeElement(int i) {
32-
return new PDelay(i);
33-
}
27+
protected BlockingQueue emptyCollection() {
28+
return new DelayQueue();
29+
}
30+
31+
protected PDelay makeElement(int i) {
32+
return new PDelay(i);
3433
}
3534

3635
private static final int NOCAP = Integer.MAX_VALUE;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
*/
6+
7+
package jsr166;
8+
9+
import java.util.concurrent.BlockingQueue;
10+
import java.util.concurrent.LinkedBlockingDeque;
11+
12+
public class LinkedBlockingDequeBoundedTest extends JSR166TestCase {
13+
14+
protected BlockingQueue emptyCollection() {
15+
return new LinkedBlockingDeque(SIZE);
16+
}
17+
18+
}

jsr166-tests/src/test/java/jsr166/LinkedBlockingDequeTest.java

-12
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,6 @@
2323

2424
public class LinkedBlockingDequeTest extends JSR166TestCase {
2525

26-
public static class Unbounded extends BlockingQueueTest {
27-
protected BlockingQueue emptyCollection() {
28-
return new LinkedBlockingDeque();
29-
}
30-
}
31-
32-
public static class Bounded extends BlockingQueueTest {
33-
protected BlockingQueue emptyCollection() {
34-
return new LinkedBlockingDeque(SIZE);
35-
}
36-
}
37-
3826
/**
3927
* Returns a new deque of given size containing consecutive
4028
* Integers 0 ... n.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
*/
6+
7+
package jsr166;
8+
9+
import java.util.concurrent.BlockingQueue;
10+
import java.util.concurrent.LinkedBlockingDeque;
11+
12+
public class LinkedBlockingDequeUnboundedTest extends BlockingQueueTest {
13+
14+
protected BlockingQueue emptyCollection() {
15+
return new LinkedBlockingDeque();
16+
}
17+
18+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.BlockingQueue;
12+
import java.util.concurrent.LinkedBlockingQueue;
13+
14+
public class LinkedBlockingQueueBoundedTest extends BlockingQueueTest {
15+
16+
protected BlockingQueue emptyCollection() {
17+
return new LinkedBlockingQueue(SIZE);
18+
}
19+
20+
}

jsr166-tests/src/test/java/jsr166/LinkedBlockingQueueTest.java

-12
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,6 @@
2424

2525
public class LinkedBlockingQueueTest extends JSR166TestCase {
2626

27-
public static class Unbounded extends BlockingQueueTest {
28-
protected BlockingQueue emptyCollection() {
29-
return new LinkedBlockingQueue();
30-
}
31-
}
32-
33-
public static class Bounded extends BlockingQueueTest {
34-
protected BlockingQueue emptyCollection() {
35-
return new LinkedBlockingQueue(SIZE);
36-
}
37-
}
38-
3927
/**
4028
* Returns a new queue of given size containing consecutive
4129
* Integers 0 ... n.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.BlockingQueue;
12+
import java.util.concurrent.LinkedBlockingQueue;
13+
14+
public class LinkedBlockingQueueUnboundedTest extends BlockingQueueTest {
15+
16+
protected BlockingQueue emptyCollection() {
17+
return new LinkedBlockingQueue();
18+
}
19+
20+
}

jsr166-tests/src/test/java/jsr166/LinkedTransferQueueTest.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,10 @@
2424
import static java.util.concurrent.TimeUnit.NANOSECONDS;
2525

2626
@SuppressWarnings({"unchecked", "rawtypes"})
27-
public class LinkedTransferQueueTest extends JSR166TestCase {
27+
public class LinkedTransferQueueTest extends BlockingQueueTest {
2828

29-
public static class Generic extends BlockingQueueTest {
30-
protected BlockingQueue emptyCollection() {
31-
return new LinkedTransferQueue();
32-
}
29+
protected BlockingQueue emptyCollection() {
30+
return new LinkedTransferQueue();
3331
}
3432

3533
/**
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.BlockingQueue;
12+
import java.util.concurrent.PriorityBlockingQueue;
13+
14+
public class PriorityBlockingQueueGenericTest extends BlockingQueueTest {
15+
16+
protected BlockingQueue emptyCollection() {
17+
return new PriorityBlockingQueue();
18+
}
19+
20+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.BlockingQueue;
12+
import java.util.concurrent.PriorityBlockingQueue;
13+
14+
public class PriorityBlockingQueueInitialCapacityTest extends BlockingQueueTest {
15+
16+
protected BlockingQueue emptyCollection() {
17+
return new PriorityBlockingQueue(SIZE);
18+
}
19+
20+
}

jsr166-tests/src/test/java/jsr166/PriorityBlockingQueueTest.java

-12
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,6 @@
2525

2626
public class PriorityBlockingQueueTest extends JSR166TestCase {
2727

28-
public static class Generic extends BlockingQueueTest {
29-
protected BlockingQueue emptyCollection() {
30-
return new PriorityBlockingQueue();
31-
}
32-
}
33-
34-
public static class InitialCapacity extends BlockingQueueTest {
35-
protected BlockingQueue emptyCollection() {
36-
return new PriorityBlockingQueue(SIZE);
37-
}
38-
}
39-
4028
private static final int NOCAP = Integer.MAX_VALUE;
4129

4230
/** Sample Comparator */
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.BlockingQueue;
12+
import java.util.concurrent.SynchronousQueue;
13+
14+
public class SynchronousQueueFairTest extends BlockingQueueTest {
15+
16+
protected BlockingQueue emptyCollection() {
17+
return new SynchronousQueue(true);
18+
}
19+
20+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Written by Doug Lea with assistance from members of JCP JSR-166
3+
* Expert Group and released to the public domain, as explained at
4+
* http://creativecommons.org/publicdomain/zero/1.0/
5+
* Other contributors include Andrew Wright, Jeffrey Hayes,
6+
* Pat Fisher, Mike Judd.
7+
*/
8+
9+
package jsr166;
10+
11+
import java.util.concurrent.BlockingQueue;
12+
import java.util.concurrent.SynchronousQueue;
13+
14+
public class SynchronousQueueNotFairTest extends BlockingQueueTest {
15+
16+
protected BlockingQueue emptyCollection() {
17+
return new SynchronousQueue(true);
18+
}
19+
20+
}

jsr166-tests/src/test/java/jsr166/SynchronousQueueTest.java

-12
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,6 @@
2424

2525
public class SynchronousQueueTest extends JSR166TestCase {
2626

27-
public static class Fair extends BlockingQueueTest {
28-
protected BlockingQueue emptyCollection() {
29-
return new SynchronousQueue(true);
30-
}
31-
}
32-
33-
public static class NonFair extends BlockingQueueTest {
34-
protected BlockingQueue emptyCollection() {
35-
return new SynchronousQueue(false);
36-
}
37-
}
38-
3927
/**
4028
* Any SynchronousQueue is both empty and full
4129
*/

0 commit comments

Comments
 (0)