-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UniBlitz shutter #1036
Comments
Not seeing any such support now in apstools. Tried searching all of GitHub. No obvious determination of state. Only known state is when it has just been set (assume that it has not been changed). There is no way to determine conclusively the state of this shutter (unless the EPICS database keeps track of it). |
It is trivial to implement controls for each of the PVs but nonsense to make it consistent with the other apstools shutter classes without a clear way to determine the state of the shutter. |
@jkirchman @kmpeters: Is there any state PV? Is it possible to add such a state PV (keeps track of the last OPEN or CLOSE command)? |
Digging deeper through the source code, the apstools/apstools/devices/shutters.py Lines 354 to 367 in 11a9707
|
uniblitz_shutter = ApsPssShutter(
"",
name="uniblitz_shutter",
open_pv=f"{PREFIX}open",
close_pv=f"{PREFIX}close"
) Apparently, both |
Note that the support uses a fixed value of apstools/apstools/devices/shutters.py Line 451 in 11a9707
and close PV: apstools/apstools/devices/shutters.py Line 464 in 11a9707
The base class supports custom values for apstools/apstools/devices/shutters.py Lines 87 to 88 in 11a9707
The base class constructor does not provide kwargs to set these. Might be a good addition, otherwise need to set shutter.close_value=1 once the shutter object is created.
|
Add to documentation that |
USAXS reports they have a UniBlitz shutter. It has two PVs, one to open the shutter and the other to close it. There is no PV for the status.
The text was updated successfully, but these errors were encountered: