Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only subscribe with event_type="setpoint" when it is available #1034

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

only subscribe with event_type="setpoint" when it is available #1034

wants to merge 4 commits into from

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the bug label Oct 29, 2024
@prjemian prjemian added this to the 1.7.2 milestone Oct 29, 2024
@prjemian prjemian self-assigned this Oct 29, 2024
canismarko
canismarko approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@canismarko canismarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this against the latest Haven version and all my tests pass. Changes look good. Thanks.

gfabbris
gfabbris approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@gfabbris gfabbris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDecarabas MDecarabas MDecarabas approved these changes

@gfabbris gfabbris gfabbris approved these changes

@canismarko canismarko canismarko approved these changes

Assignees

@prjemian prjemian

Labels
bug
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.

PVPositionerSoftDone uses invalid subscription event type for simulated devices
4 participants
@prjemian @canismarko @gfabbris @MDecarabas