Catch exception precisely, and change an api url #3278
Conversation
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
| ); | ||
| ViewData["name"] = user.DisplayName; | ||
| } | ||
| catch (Exception) |
There was a problem hiding this comment.
actually no, you should not do that. as there is an attribute to catch the exception.
Did you see the [AuthorizeForScopes(Scopes = new[] { "user.read" })] attribute, @rayluo ?
See Managing incremental consent and conditional access for details
There was a problem hiding this comment.
It is true that the sample still works as-is without this part of change.
The reason I made this change is because I ran into an exception in await _graphServiceClient.Me.GetAsync(...) after I experimentally changed the "BaseUrl" in appsettings.json from https://graph.microsoft.com/beta to https://graph.microsoft.com/v1.0/me. Presumably the _graphServiceClient.Me.GetAsync(...) is only expected to work with that preconfigured MS Graph beta endpoint. In any case, this change shall make the sample more robust.
|
@rayluo : let's start to raise a GitHub issue with the customer problem (and repro steps)? |
{PR title}
Summary of the changes (Less than 80 chars):
Before this change, the
ViewData["json"]was not populated.