Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: FunctionApp Can't Be Deployed when on Consumption #1797

Open
1 task done
jreinhardtproarch opened this issue Apr 30, 2024 · 6 comments
Open
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@jreinhardtproarch
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/web/site

(Optional) Module Version

0.3.4

Description

This claims to be able to deploy a FunctionApp. However, the default appSettings it deploys only include the storage setting WebSiteJobsStorage (see main.bicep line 72. This means that, per https://learn.microsoft.com/en-us/azure/azure-functions/functions-recover-storage-account#storage-account-application-settings-were-deleted, this template assumes that an Elastic Premium and Consumption plan are not being used as per that link.

I would propose that the template be updated to ensure that the connection string appSetting WEBSITE_CONTENTAZUREFILECONNECTIONSTRING is deployed if a consumption app or elastic premium server farm is linked and that the file share is also created in the linked storage account with a corresponding appSetting WEBSITE_CONTENTSHARE. Is this doable?

(Optional) Correlation Id

No response

@jreinhardtproarch jreinhardtproarch added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Apr 30, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Apr 30, 2024

Note

The "Type: Bug 🐛" label was added as per ITA21.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Apr 30, 2024
Copy link

@jreinhardtproarch, thanks for submitting this issue for the avm/res/web/site module!

Important

A member of the @Azure/avm-res-web-site-module-owners-bicep or @Azure/avm-res-web-site-module-contributors-bicep team will review it soon!

@tsc-buddy
Copy link
Contributor

Hi @jreinhardtproarch thanks for submitting the issue. We shall schedule some triage time in for later in May to take a look at this. Thanks Again.

@tsc-buddy tsc-buddy removed the Needs: Triage 🔍 Maintainers need to triage still label May 3, 2024
@IngerMathilde
Copy link

Hi! Any update on this issue?

@wsmelton
Copy link
Contributor

wsmelton commented Jan 6, 2025

The module itself isn't written in a way, nor documented, that allows users to deploy a function app using each plan type. User must depend on the errors from a deployment to identify what is missing (e.g., parameter use dictating what App Setting value is generated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Triage
Development

No branches or pull requests

5 participants