Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always comment on every unsafe usage describing why the unsafe usage is sound #109

Open
BarryBo opened this issue Dec 6, 2022 · 1 comment

Comments

@BarryBo
Copy link
Contributor

BarryBo commented Dec 6, 2022

    It would be really awesome if this library always had comments on every `unsafe` usage describing why the `unsafe` usage is sound. Something like:
// UNSAFE: $REASON

Originally posted by @rylev in #101 (comment)

@BarryBo
Copy link
Contributor Author

BarryBo commented Dec 6, 2022

I filed a work item for this. The blanket answer is they are all calling through FFI code with types that are unsafe. But I'll make a pass and comment them all, so lint tools are happy :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant