Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo-azsphere is calling name.to_string every time which is an unnecessary allocation. It's preferable to call unwrap_or_else. #107

Open
BarryBo opened this issue Dec 6, 2022 · 0 comments
Open

Cargo-azsphere is calling name.to_string every time which is an unnecessary allocation. It's preferable to call unwrap_or_else. #107

BarryBo opened this issue Dec 6, 2022 · 0 comments

Comments

@BarryBo
Copy link
Contributor

BarryBo commented Dec 6, 2022 

    You're calling `name.to_string` every time which is an unnecessary allocation. It's preferable to call `unwrap_or_else`. Granted this isn't a very hot code path so in practice, it won't make a difference.

Originally posted by @rylev in #101 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BarryBo