Fixed bug when using Find-AzUpgradeCommandReference -DirectoryPath #[121] (#122)

* bugfix

* fix

* fix test

* upgrade version

Author: VeryEarly

Diff for: powershell-module/Az.Tools.Migration/Az.Tools.Migration.psd1

@@ -3,7 +3,7 @@
     RootModule = 'Az.Tools.Migration.psm1'
 
     # Version number of this module.
-    ModuleVersion = '2.0.0'
+    ModuleVersion = '2.0.1'
 
     # Supported PSEditions
     CompatiblePSEditions = 'Core', 'Desktop'
@@ -108,16 +108,7 @@
             # IconUri = ''
 
             # ReleaseNotes of this module
-            ReleaseNotes = "* Supported AzureRM to Az 10.3 migration
-            * `Get-AzUpgradeAliasSpec`
-                * Parameter `ModuleVersion` now accept value 'latest' only [BreakingChange]
-            * `Get-AzUpgradeCmdletSpec`
-                * Parameter `ModuleName` removed` [BreakingChange]
-                * Added switch parameters `AzureRM` and `Az`
-                * Parameter `ModuleVersion` now accept value 'latest' only and has to be used with `Az` [BreakingChange]
-            * `New-AzUpgradeModulePlan`
-                * Parameter `ToAzVersion` now accept value 'latest' only [BreakingChange]
-                * Parameter `FilePath` now accept relative file path"
+            ReleaseNotes = "* Fixed bug when using `Find-AzUpgradeCommandReference -DirectoryPath` #[121]"
         }
     }
 

Diff for: powershell-module/Az.Tools.Migration/Functions/Public/Find-AzUpgradeCommandReference.ps1

@@ -92,7 +92,6 @@ function Find-AzUpgradeCommandReference
     Process
     {
         $cmdStarted = Get-Date
-        $FilePath = (Resolve-Path $FilePath).Path
 
         if ($PSBoundParameters.ContainsKey('AzureRmModuleSpec') -eq $false)
         {
@@ -112,6 +111,7 @@ function Find-AzUpgradeCommandReference
                 throw "File was not found or was not accessible: $FilePath"
             }
 
+            $FilePath = (Resolve-Path $FilePath).Path
             Write-Verbose -Message "Searching for AzureRM references in file: $FilePath"
             $foundCmdlets = Find-CmdletsInFile -FilePath $FilePath | Where-object -FilterScript { $AzureRmModuleSpec.ContainsKey($_.CommandName) -eq $true }
 
@@ -138,6 +138,7 @@ function Find-AzUpgradeCommandReference
                 throw "Directory was not found or was not accessible: $DirectoryPath"
             }
 
+            $DirectoryPath = (Resolve-Path $DirectoryPath).Path
             $filesToSearch = Get-ChildItem -Path $DirectoryPath -Recurse -Include *.ps1, *.psm1
             $commandCounter = 0
 

Diff for: powershell-module/Az.Tools.Migration/Functions/Public/New-AzUpgradeModulePlan.ps1

@@ -122,7 +122,6 @@ function New-AzUpgradeModulePlan
     {
         $cmdStarted = Get-Date
 
-        $FilePath = (Resolve-Path $FilePath).Path
         $versionPath = Join-Path -Path $MyInvocation.MyCommand.Module.ModuleBase -ChildPath "\Resources\ModuleSpecs\Az\$ToAzVersion"
         $version = Get-ChildItem -Path $versionPath -Name
 
@@ -131,6 +130,7 @@ function New-AzUpgradeModulePlan
 
         if ($PSCmdlet.ParameterSetName -eq 'FromNewSearchByFile')
         {
+            $FilePath = (Resolve-Path $FilePath).Path
             if ($PSBoundParameters.ContainsKey('AzureRmModuleSpec'))
             {
                 Write-Verbose -Message "Searching for commands to upgrade, by file, with pre-loaded module spec."
@@ -144,6 +144,7 @@ function New-AzUpgradeModulePlan
         }
         elseif ($PSCmdlet.ParameterSetName -eq 'FromNewSearchByDirectory')
         {
+            $DirectoryPath = (Resolve-Path $DirectoryPath).Path
             if ($PSBoundParameters.ContainsKey('AzureRmModuleSpec'))
             {
                 Write-Verbose -Message "Searching for commands to upgrade, by directory, with pre-loaded module spec."

Diff for: powershell-module/Az.Tools.Migration/Tests/Functions/Public/Find-AzUpgradeCommandReference.tests.ps1

@@ -6,6 +6,8 @@ InModuleScope -ModuleName Az.Tools.Migration -ScriptBlock {
             # arrange
             Mock -CommandName Test-Path -MockWith { Write-Output -InputObject $true }
 
+            Mock -CommandName Resolve-Path -MockWith { @{Path = $Path} }
+
             # ensure we don't send telemetry during tests.
             Mock -CommandName Send-MetricsIfDataCollectionEnabled -ModuleName Az.Tools.Migration -MockWith { }
 

Diff for: powershell-module/ChangeLog.md

@@ -19,6 +19,9 @@
 -->
 ## Upcoming Release
 
+## 2.0.1
+* Fixed bug when using `Find-AzUpgradeCommandReference -DirectoryPath` #[121]
+
 ## 2.0.0
 * Supported AzureRM to Az 10.3 migration
 * `Get-AzUpgradeAliasSpec`