Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add support for amqps ? #156

Open
LZorglub opened this issue Mar 7, 2021 · 2 comments
Open

Can you add support for amqps ? #156

LZorglub opened this issue Mar 7, 2021 · 2 comments

Comments

@LZorglub
Copy link

LZorglub commented Mar 7, 2021

Will be very helpfull to be able to provide ssl options in RabbitMQOptions like :

.AddRabbitMQ(options =>
{
       options.Ssl.Enabled = true;
        options.Ssl.ServerName = serverName;
        options.Ssl.CertPath = @"certificate.p12";
        options.Ssl.CertPassphrase = "passphrase";
});

or better by providing the certificate collection.

options.Ssl.Certs = new X509CertificateCollection
{
     new X509Certificate2(privateKeyBytes, (string)null)
};
@cachai2 cachai2 added the enhancement New feature or request label Mar 22, 2021
@JatinSanghvi JatinSanghvi self-assigned this Jan 29, 2022
@JatinSanghvi
Copy link
Contributor

JatinSanghvi commented Feb 21, 2022

Adding few points on the old issue: The first two properties (Ssl.Enabled and Ssl.ServerName) will get set automatically once we use connection string starting with amqps:// (code reference).

Regarding providing a way to supply certificate collection, I doubt if that would be possible. As per my knowledge, the RabbitMQOption get deserialized from host.json when the function is running in context of an Azure Function App. We would like all Options and binding fields to be JSON-parseable. This prevents having a non-POCO C# classes (like X509Certificate2 class instance) as an option. Would like to know if I am making an error and the limitation does not exist.

@ielcoro
Copy link

ielcoro commented Jun 23, 2022

What would be great is to specify a certificate thumbprint and password to an configured app service certificate. Also a keyvault reference could do the job.

@JatinSanghvi JatinSanghvi removed their assignment Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants