Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Cloud Config reading from ARM metadata with API Version 2022-09-01 #25815

Open
bganapa opened this issue Mar 15, 2023 · 1 comment · May be fixed by #30682 or #25834
Open

Initialize Cloud Config reading from ARM metadata with API Version 2022-09-01 #25815

bganapa opened this issue Mar 15, 2023 · 1 comment · May be fixed by #30682 or #25834
Assignees
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team Cloud feature-request
Milestone

Comments

@bganapa
Copy link
Member

bganapa commented Mar 15, 2023

Related command
az cloud register

Is your feature request related to a problem? Please describe.
Azure Stack needs custom endpoints and many of the azure code bases have hard coded the values in various places depending on the cloud name. This will not work for disconnected custom clouds like Azure Stack as the endpoints are defined by the customer configurations.

We worked with ARM team to provide the custom dataplane endpoints through the ARM metadata with a newer api version 2022-09-01

Describe the solution you'd like
CLI cloud config should read the ARM metadata with api version 2022-09-01 instead of the current 1.0 and expose them in CLI Context so that all the extensions could make use of it

Describe alternatives you've considered

Other alternatives are hardcoding the values, or making the ARM metadata request with api version 2022-09-01 in CLI extensions like connectedk8s, k8s-extensions, k8s-configuration etc..

Additional context
Additional context is shared via internal mail.

The followign are the new fields added with api version 2022-09-01

"suffixes":{
"relayEndpointSuffix":"servicebus.azs.microsoft.com",
...
},
dataplaneEndpoints":{
"arcConfigEndpoint":"https://edge.dp.kubernetesconfiguration.azs.microsoft.com/",
"arcGlobalNotificationServiceEndpoint":"https://guestnotificationservice.azs.microsoft.com/",
"arcHybridIdentityServiceEndpoint":"https://his.azs.microsoft.com/",
"globalContainerRegistryEndpoint":"edgemcr.edgeacr.azs.microsoft.com",
"arcGuestConfigEndpoint":"https://agentserviceapi.azs.microsoft.com/"
},

@yonzhan yonzhan added Cloud feature-request Azure CLI Team The command of the issue is owned by Azure CLI team labels Mar 15, 2023
@yonzhan yonzhan added this to the Backlog milestone Mar 15, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 15, 2023

@jiasli for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment