Support install of git submodules. #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`azdev setup` command looks for git repositories in various cases (e.g. install azure-cli from source). It is a valid use case that the source repos are not standalone git repositories but they are checked out as git submodules. In this case, the .git entry is not a directory but it is a file with reference to the parent repository. For example: $ cat .git gitdir: ../../.git/modules/src/azure-cli To support this use case, the setup.py:_check_repo() function has been extended to check for file existence not only for directory existence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azdev setupcommand looks for git repositories in various cases (e.g.install azure-cli from source). It is a valid use case that the source
repos are not standalone git repositories but they are checked out as git
submodules. In this case, the .git entry is not a directory but it
is a file with reference to the parent repository. For example:
$ cat .git
gitdir: ../../.git/modules/src/azure-cli
To support this use case, the setup.py:_check_repo() function has been
extended to check for file existence not only for directory existence.