From 75a1a7981024106d711fe76f2a5a5af589524f0b Mon Sep 17 00:00:00 2001 From: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> Date: Tue, 25 Aug 2020 15:18:13 +0800 Subject: [PATCH] [Linter] Fix minor display issue in azdev linter (#259) * fix display issue * bump version and add history * refract * format output --- HISTORY.rst | 4 ++++ azdev/__init__.py | 2 +- azdev/operations/linter/__init__.py | 8 ++++---- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/HISTORY.rst b/HISTORY.rst index 2c747cc1..cb32acd8 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -2,6 +2,10 @@ Release History =============== +0.1.28 +++++++ +* [Linter] Fix minor display issue in `azdev linter`. + 0.1.27 ++++++ * [Linter] "Show" command should use `show_command` or `custom_show_command`. diff --git a/azdev/__init__.py b/azdev/__init__.py index ccdb3a5b..76eeb4b7 100644 --- a/azdev/__init__.py +++ b/azdev/__init__.py @@ -4,4 +4,4 @@ # license information. # ----------------------------------------------------------------------------- -__VERSION__ = '0.1.27' +__VERSION__ = '0.1.28' diff --git a/azdev/operations/linter/__init__.py b/azdev/operations/linter/__init__.py index 5d80bd07..a1ed86fe 100644 --- a/azdev/operations/linter/__init__.py +++ b/azdev/operations/linter/__init__.py @@ -160,8 +160,7 @@ def run_linter(modules=None, rule_types=None, rules=None, ci_exclusions=None, run_commands=not rule_types or 'commands' in rule_types, run_command_groups=not rule_types or 'command_groups' in rule_types, run_help_files_entries=not rule_types or 'help_entries' in rule_types) - logger.info(os.linesep) - logger.info('Run custom pylint rules.') + display(os.linesep + 'Run custom pylint rules.') exit_code += pylint_rules(selected_modules) sys.exit(exit_code) @@ -178,9 +177,10 @@ def pylint_rules(selected_modules): pylint_result = run_pylint(selected_modules, env=my_env, checkers=checkers, disable_all=True, enable=enable) if pylint_result and not pylint_result.error: display(os.linesep + 'No violations found for custom pylint rules.') + display('Linter: PASSED\n') if pylint_result and pylint_result.error: - logger.info(pylint_result.error.output.decode('utf-8')) - logger.info('Linter: FAILED\n') + display(pylint_result.error.output.decode('utf-8')) + display('Linter: FAILED\n') return pylint_result.exit_code