Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] BREAKING change: Add options to split validation and publication resources #1085

Open
Tracked by #1607
MariusStorhaug opened this issue Mar 5, 2022 · 6 comments · May be fixed by #1608
Open
Tracked by #1607
Assignees
Labels
blocked if an issue is blocked [cat] publishing category: publishing enhancement New feature or request

Comments

@MariusStorhaug
Copy link
Contributor

MariusStorhaug commented Mar 5, 2022

Description

Add options to have validation and testing separate from the subscription where modules are published.
Assuming that in a ALZ landing zone a sandbox might be required for validation and testing, while published modules/template specs need to go to a separate "Automation" subscription.

If this exists, we need to add guidance for how to set up using a dual subscription setup.

We probably need to consider changing the prefix of the ARM_* variables to split the two environments:

  • GH: Create separate prefixes for validation and publication:
    • VALIDATION_
    • PUBLISHING_
  • ADO: Add something like this for serviceConnections:
    • serviceConnectionValidation = 'your-servicecon-name'
    • serviceConnectionPublish = $(serviceConnectionValidation)
@MariusStorhaug MariusStorhaug added the enhancement New feature or request label Mar 5, 2022
@AlexanderSehr
Copy link
Contributor

I guess it will come down to adding another service connection and referencing it in the publishing. Good idea

@eriqua
Copy link
Contributor

eriqua commented Mar 22, 2022

Did we ever discuss about that? I'd even say it should be a priority. It would also be consistent with our diagram. Good catch!

@AlexanderSehr AlexanderSehr added the [cat] publishing category: publishing label Apr 19, 2022
@SeSeicht
Copy link
Contributor

SeSeicht commented Jun 3, 2022

I already did that and will create a PR for that the next days

@MariusStorhaug
Copy link
Contributor Author

Looking to include approach with the wider changes to OIDC updates, as it requires environment or other known "properties". Will try to add this as separate environments.

@MariusStorhaug MariusStorhaug changed the title Add options to split validation and publication resources [Feature Request]: Add options to split validation and publication resources Jun 26, 2022
@MariusStorhaug MariusStorhaug removed a link to a pull request Jun 26, 2022
10 tasks
@eriqua eriqua changed the title [Feature Request]: Add options to split validation and publication resources [Feature Request] BREAKING change: Add options to split validation and publication resources Jul 25, 2022
@eriqua
Copy link
Contributor

eriqua commented Sep 1, 2022

Removing from upcoming release 0.7, will be worked on in the next one

@eriqua eriqua removed this from the Release 0.7 milestone Sep 1, 2022
@rahalan rahalan added the blocked if an issue is blocked label Nov 10, 2022
@rahalan
Copy link
Contributor

rahalan commented Nov 10, 2022

Waiting for investigation of #1450

@rahalan rahalan moved this to Blocked in Backlog Dec 11, 2022
@rahalan rahalan added this to Backlog Dec 11, 2022
@AlexanderSehr AlexanderSehr added this to the Azure Verfified Modules (AVM) - V3 milestone May 19, 2024
@AlexanderSehr AlexanderSehr removed this from the Azure Verfified Modules (AVM) - CI Issues milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked if an issue is blocked [cat] publishing category: publishing enhancement New feature or request
Projects
Status: Blocked
5 participants