Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Refactor QuestionAnsweringBenchmarkOrchestrator to be a subclass of PromptSendingOrchestrator #656

Open
rdheekonda opened this issue Jan 23, 2025 · 1 comment
Open

MAINT: Refactor QuestionAnsweringBenchmarkOrchestrator to be a subclass of PromptSendingOrchestrator #656

rdheekonda opened this issue Jan 23, 2025 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rdheekonda
Copy link
Contributor

Is your feature request related to a problem? Please describe.

QuestionAnsweringBenchmarkOrchestrator should be a single turn orchestrator, prepending the right conversations. See how flip attack orchestrator works.

This will make for better and more usable code.

Could also refer to this PR for reference.: https://github.com/Azure/PyRIT/pull/650/files
@rdheekonda rdheekonda added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 23, 2025
AdrGav941 added a commit to AdrGav941/PyRIT that referenced this issue Jan 31, 2025
@AdrGav941
Merge branch 'main' into MAINT--Refactor-QuestionAnsweringBenchmarkOr…
262414d 
…chestrator-to-be-a-subclass-of-PromptSendingOrchestrator-Azure#656
@AdrGav941 AdrGav941 mentioned this issue Jan 31, 2025
Closed
@rlundeen2 rlundeen2 removed the good first issue Good for newcomers label Feb 1, 2025
@rlundeen2
Copy link
Contributor

Removing the good first issue tag. I think this one is nuanced!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rdheekonda @rlundeen2