Bug: "Default Networking" mode not compatible with Azure CNI Overlay #618
Labels
bug
Something isn't working
good first issue
Good for newcomers
helper-ui 🧙♀️
An issue with the UI in the helper
Describe the bug
Currently, it is possible to select the "Default Networking" and "CNI Overlay Network" options on the "Networking Details", but this will result in a cluster with nodes and pods running in the same subnet (i.e. pods not running in the overlay subnet, as expected). We should add some warnings to make it clear to users that this is the case (or even prevent them from copying the shell scripts, like if an IP address is missing and allowed IP ranges is enabled on the cluster).
To Reproduce
Steps to reproduce the behavior:
If you deploy this cluster, you will get pods running in the same subnet as the nodes, which is not as expected. It doesn't seem to be possible to fix this once the cluster is deployed.
When selecting "Default Networking", there is a pop-over with the following information, but it doesn't mention CNI Overlay (presumably because it was in preview until 30th May):
![image](https://private-user-images.githubusercontent.com/6115202/253000575-5617334d-41a9-431f-86be-ab35fdfaae45.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDMwMjYsIm5iZiI6MTczOTM0MjcyNiwicGF0aCI6Ii82MTE1MjAyLzI1MzAwMDU3NS01NjE3MzM0ZC00MWE5LTQzMWYtODZiZS1hYjM1ZmRmYWFlNDUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDY0NTI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Njk5NDIxNDlmNTk2Yzk0OTFmMzQ0NzRlNTMyZjg0OTI1NDQ2MTM1ZjlhODhiYzIyMjQ2NWVjMDIzOTZmYWI2ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.QJlOrKu8EuBjXVmY0_VV6hTmWj7P01PqzFUkckYVc7c)
Expected behavior
![image](https://private-user-images.githubusercontent.com/6115202/253000324-96efcedd-440f-4371-9d1a-f50642369b07.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDMwMjYsIm5iZiI6MTczOTM0MjcyNiwicGF0aCI6Ii82MTE1MjAyLzI1MzAwMDMyNC05NmVmY2VkZC00NDBmLTQzNzEtOWQxYS1mNTA2NDIzNjliMDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDY0NTI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjRkZWQ1M2Q5NTBkZWQ0OTQ4ZWJiMmVhYzU2Njg2OThkNDZiZDMxNTJjNTUwOTM5NzRmMjgyNDIyYWUyM2FkMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.akGSxG5v8w69hy5bdtzxLeZFImYiT0IEKsn-OhU-neI)
I think a stronger notification is required to inform the user that the selected options are not a compatible configuration. Something like the warning provided when Azure AppGW Ingress Controller add-on is selected with "Enable KeyVault Integration for TLS certificates", but the Secrets Store CSI driver is not provisioned into the cluster:
Or maybe provide a waning and prevent them from copying the shell scripts, like in the case when "allowed IP ranges" is enabled on the cluster, but an IP address/range is not provided:
![image](https://private-user-images.githubusercontent.com/6115202/252997108-2372bd28-db0a-45fa-af62-89d014a19f62.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDMwMjYsIm5iZiI6MTczOTM0MjcyNiwicGF0aCI6Ii82MTE1MjAyLzI1Mjk5NzEwOC0yMzcyYmQyOC1kYjBhLTQ1ZmEtYWY2Mi04OWQwMTRhMTlmNjIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDY0NTI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmM0ODc2ZTI0NjM3MjcwZDEyNjE4YzRmMzFlN2NhZjZjODJmMGZiOTAxZDA1MGRjMzAyYWUxMTQ0ODNjYmJmNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.SmQXa4S1AD9-OpVvWezmRvuxRlc6LNX2Uciy1Rxr4Tk)
A clear and concise description of what you expected to happen.
AKS Construction should warn me that I have created an invalid configuration which will not work in the way I might be expecting.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Related to #617
The text was updated successfully, but these errors were encountered: