Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default needed for osDiskSizeGb parameter #612

Closed
Gordonby opened this issue Jul 9, 2023 · 5 comments
Closed

New default needed for osDiskSizeGb parameter #612

Gordonby opened this issue Jul 9, 2023 · 5 comments
Assignees

Comments

@Gordonby
Copy link
Collaborator

Gordonby commented Jul 9, 2023

Describe the bug
The current default value for parameter osDiskSizeGB is 0.
The effect of this is that the AKS RP ignores the value and instead uses the value of 128GB.

As the size of the Ubuntu image is ~30GB, this means we're unnecessarily defaulting to a much bigger size disk than is needed.
Windows nodes, will indeed need a larger disk.

I think this is also related to #592

To Reproduce
Deploy a cluster and inspect the disk size

Expected behavior
An appropriately size disk will be chosen by AKSC to fit the requirement of either Linux or Windows. (32 or 128 i believe would be a good choice.)

Screenshots
image

Additional context

" Standard Ubuntu server image from Marketplace is about 30 GiB. The temp disk size must be equal to or larger than 30 GiB to enable Ephemeral OS disk on the temporary storage. Standard_B4ms has a temporary storage size of 32 GiB, which can fit the 30 GiB OS disk. Upon creation of the VM, the temp disk space would be 2 GiB."

"Standard Windows Server images from the Marketplace are about 127 GiB, meaning that you need a VM size with a cache equal to or larger than 127 GiB. The Standard_DS3_v2 has a cache size of 127 GiB, which is large enough. In this case, the Standard_DS3_v2 is the smallest size in the DSv2 series that you can use with this image."

ref: https://learn.microsoft.com/en-us/samples/azure-samples/aks-ephemeral-os-disk/aks-ephemeral-os-disk/

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Aug 9, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2023
@Gordonby Gordonby reopened this Sep 10, 2023
@Gordonby Gordonby removed the stale An issue that hasn't had a lot of love recently label Sep 10, 2023
@iamvighnesh iamvighnesh self-assigned this Oct 10, 2023
@iamvighnesh
Copy link
Contributor

@Gordonby I am happy to make this quick change. I suggest we use the following:

  • Linux defaults to 30Gb
  • Windows defaults to 100Gb

Copy link
Contributor

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Nov 10, 2023
@iamvighnesh iamvighnesh removed the stale An issue that hasn't had a lot of love recently label Nov 10, 2023
@Gordonby
Copy link
Collaborator Author

I wonder if the Windows default could be more configurable.... 100GB would require quite a big VM to use an ephemeral disk. I'd need to check vm disk sizes, but something more like 50GB would be good.

@pjlewisuk
Copy link
Contributor

Resolved in #661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants