Skip to content

Commit fad8882

Browse files
authored
Interim checking: TODO markers are changes (#138)
1 parent 7d69f94 commit fad8882

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

infra/core/ai/hub.bicep

+14-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ param publicNetworkAccess string = 'Enabled'
2727
param location string = resourceGroup().location
2828
param tags object = {}
2929

30-
resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' = {
30+
// NN:TODO resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' = {
31+
resource hub 'Microsoft.MachineLearningServices/workspaces@2024-04-01' = {
3132
name: name
3233
location: location
3334
tags: tags
@@ -54,6 +55,7 @@ resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' =
5455
discoveryUrl: 'https://${location}.api.azureml.ms/discovery'
5556
}
5657

58+
/* NN:TODO
5759
resource contentSafetyDefaultEndpoint 'endpoints' = {
5860
name: 'Azure.ContentSafety'
5961
properties: {
@@ -62,16 +64,25 @@ resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' =
6264
associatedResourceId: openAi.id
6365
}
6466
}
67+
*/
6568

66-
resource openAiConnection 'connections' = {
69+
/*
70+
NN:TODO
71+
Connections are not in the GA Swagger - they are only in public preview of 2024-04-01-preview version
72+
That is what you specify with the workspace@ version for AML API version
73+
The ApiVersion specified in the metadata is for the Azure Cognitive Services version (that wraps the OpenAPI call)
74+
*/
75+
76+
resource openAiConnection 'connections@2024-04-01-preview' = { // NN:TODO Add @version to ensure resource is correctly versioned
6777
name: 'aoai-connection'
6878
properties: {
6979
category: 'AzureOpenAI'
7080
authType: 'ApiKey'
7181
isSharedToAll: true
7282
target: openAi.properties.endpoints['OpenAI Language Model Instance API']
7383
metadata: {
74-
ApiVersion: '2023-07-01-preview'
84+
//ApiVersion: '2023-07-01-preview'
85+
ApiVersion: '2024-02-01'
7586
ApiType: 'azure'
7687
ResourceId: openAi.id
7788
}

0 commit comments

Comments
 (0)