Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Accept multiple consensus client endpoints #12747

Open
aminsammara opened this issue Mar 14, 2025 · 3 comments · May be fixed by #13022
Open

feat: Accept multiple consensus client endpoints #12747

aminsammara opened this issue Mar 14, 2025 · 3 comments · May be fixed by #13022
Assignees

Comments

@aminsammara
Copy link
Contributor

Received feedback from provers: they want to use multiple endpoints for the consensus rpc as fallback in case one goes down. We already have this for the execution rpc.

@aminsammara aminsammara self-assigned this Mar 14, 2025
@natebeauregard
Copy link
Contributor

@aminsammara Are there any concerns with backwards compatibility with this change? Should I leave the existing L1_CONSENSUS_HOST_URL env var as is or would it be fine if I updated it to be L1_CONSENSUS_HOST_URLS and then require nodes to reconfigure?

@natebeauregard
Copy link
Contributor

@aminsammara As a follow up question, will we also want to modify L1_CONSENSUS_HOST_API_KEY and L1_CONSENSUS_HOST_API_KEY_HEADER to be lists that correspond to the same L1 consesnsus client index in L1_CONSENSUS_HOST_URL? I know you mentioned that the API key values weren't used too often so I wanted to double check before implementing lists for those values as well.

@aminsammara
Copy link
Contributor Author

@natebeauregard this is a non-protocol change so i'm comfortable with having nodes reconfigure.

The two ways to use this should be:

  1. An operator provides three lists of endpoints. The i'th value in L1_CONSENSUS_HOST_URL is concatenated with ith value in L1_CONSENSUS_HOST_API_KEY and ith in L1_CONSENSUS_HOST_API_KEY_HEADER, and so on.
  2. An operator provides a list of endpoints in L1_L1_CONSENSUS_HOST_URL.

If that's not clear lmk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants