Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: fix error in parseImageData on invalid pixbuf #238

Merged
merged 2 commits into from
Jan 6, 2024
Merged

notifications: fix error in parseImageData on invalid pixbuf #238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7136467
notifications: fix error in parseImageData on invalid pixbuf
vaxerski Jan 3, 2024
4b5674b
check bits
Aylur Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/service/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,18 @@ export class Notification extends Service {
const [w, h, rs, alpha, bps, _, data] = imageData // iiibiiay
.recursiveUnpack<[number, number, number, boolean, number, number, GLib.Bytes]>();

if (bps !== 8) {
console.warn(`Notification image error from ${this.app_name}: ` +
'Currently only RGB images with 8 bits per sample are supported.');
return null;
}

const pixbuf = GdkPixbuf.Pixbuf.new_from_bytes(
data, GdkPixbuf.Colorspace.RGB, alpha, bps, w, h, rs);

if (!pixbuf)
return null;

const outputStream = Gio.File.new_for_path(fileName)
.replace(null, false, Gio.FileCreateFlags.NONE, null);

Expand Down