Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: fix error in parseImageData on invalid pixbuf #238

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

vaxerski
Copy link
Contributor

@vaxerski vaxerski commented Jan 3, 2024

Fixes nheko notifs

regards

I give you all the copyright for this code I don't care just please merge I beg

@Aylur
Copy link
Owner

Aylur commented Jan 3, 2024

Currently only RGB images with 8 bits per sample are supported.

Maybe we should have an even earlier return on bps !== 8

@vaxerski
Copy link
Contributor Author

vaxerski commented Jan 3, 2024

we can, but this should be a better catch-all for whatever shenanigans might happen

@Aylur Aylur merged commit 3f12ab5 into Aylur:main Jan 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants