Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Card component from migration credentials screen #94729

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Sep 19, 2024

Related to #94709.

Proposed Changes

  • Removes the Card component from the migration credentials screen.

Why are these changes being made?

  • To bring the migration flow UI closer to the onboarding flow UI as per p9Jlb4-ee4-p2#comment-13481.

Testing Instructions

  • Proceed through the migration flow.
  • On the "How do you want to migrate?" step, choose "Do it for me".
  • Verify that there is no border around the form and that the background of the page is all the same color.
  • Remove the conditional here to see the error.
  • Ensure the error message spacing looks good.

Screenshot 2024-09-19 at 3 10 08 PM

Screenshot 2024-09-19 at 3 10 54 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@donnapep donnapep self-assigned this Sep 19, 2024
@donnapep donnapep linked an issue Sep 19, 2024 that may be closed by this pull request
1 task
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
@donnapep donnapep requested a review from m1r0 September 19, 2024 19:28
@donnapep
Copy link
Contributor Author

donnapep commented Sep 19, 2024

To whoever reviews this PR, kindly merge once approved as I'll be AFK. 🙂

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just noticed an issue in mobile view where the skip link at the bottom was getting out of view and it wasn't possible to scroll down to it. So I added a quick fix here -

Screen.Recording.2024-09-20.at.7.22.23.AM.mov

@Imran92 Imran92 merged commit 2d13ba1 into trunk Sep 20, 2024
11 checks passed
@Imran92 Imran92 deleted the remove/site-migration-credentials-card-component branch September 20, 2024 02:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Remove the background and border from the credentials collection form
3 participants