Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing shipping address doesn't update shipping rates or taxes #218

Open
2 tasks done
Jinksi opened this issue Oct 12, 2022 · 5 comments · May be fixed by #219
Open
2 tasks done

Changing shipping address doesn't update shipping rates or taxes #218

Jinksi opened this issue Oct 12, 2022 · 5 comments · May be fixed by #219
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@Jinksi
Copy link
Member

Jinksi commented Oct 12, 2022

Describe the bug

When customers update a subscription's shipping address, shipping rates or taxes aren't updated.

To Reproduce

  1. Create 2+ shipping zones with different flat rates.
  2. Purchase a subscription.
  3. From the My Account page, change the subscription shipping address to a different shipping zone.
  4. Notice that the shipping cost hasn't changed.

Expected behavior

  1. If a customer changes a subscription's address, the shipping cost should be recalculated and applied to renewals.
  2. The customer should be able to see the change in cost when updating the address.

Actual behavior

Shipping (and taxes) cost isn't updated for renewals when the shipping address for the subscription is updated.

Product impact

Additional context

Previous (closed) PRs addressing this issue, before subs-core:
@Jinksi Jinksi added type: bug The issue is a confirmed bug. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Oct 12, 2022
@Jinksi Jinksi added this to the 2.4 milestone Oct 12, 2022
@Jinksi Jinksi self-assigned this Oct 12, 2022
This was referenced Oct 12, 2022
Open
Open
@Jinksi Jinksi linked a pull request Oct 12, 2022 that will close this issue
Update shipping and taxes via checkout page when changing subscription address (classic checkout) #219
Open
13 tasks
@Jinksi Jinksi removed this from the 2.4 milestone Oct 27, 2022
@Jinksi Jinksi removed their assignment Jun 6, 2023
@Jinksi
Copy link
Member Author

Jinksi commented Jun 6, 2023

FYI @woocommerce/quark: I’ve unassigned myself from this issue and I'll hand it over to your maintenance process. 🙏

@namiokuzono
Copy link

6928015-zd-a8c

@nicdwilson
Copy link

nicdwilson commented Oct 3, 2023 •
edited
Loading

In 6928015-zen we've provided the merchant with a very roughly put together trigger for AutomateWoo, which fires when the subscription address is changed. It would be a great help if we could fire the trigger after the address is changed to the subscription, but this does not seem to be possible, since the callback exits.

I get that this is a complex problem to approach, but as it has been outstanding for some time, as an interim step, would it be possible to add an action which fires after a successful change? This one line change would allow third parties (such as AutomateWoo) to at least add a shipping recalculation action based on current subscription address details.

@ncsramona
Copy link

#7150603-zen

@malithsen
Copy link
Member

7656123-zd-a8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
5 participants
@Jinksi @nicdwilson @malithsen @namiokuzono @ncsramona