Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'deposit' to 'payout' in Wiki section #9672

Open
nagpai opened this issue Nov 5, 2024 · 4 comments
Open

Rename 'deposit' to 'payout' in Wiki section #9672

nagpai opened this issue Nov 5, 2024 · 4 comments
Assignees
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: deposits

Comments

@nagpai
Copy link
Contributor

nagpai commented Nov 5, 2024

All instances of 'deposit' within the wiki needs to be renamed to 'payout'.

https://github.com/Automattic/woocommerce-payments/wiki (critical flows etc).

The wiki mainly consists of release related documentation referred to by Global Step and hence should be pushed only after the UI related renaming changes are merged.

The issue is a part of a larger project to rename 'deposit' to 'payout' across the codebase.

@nagpai nagpai added category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: deposits labels Nov 5, 2024
@Jinksi Jinksi self-assigned this Nov 11, 2024
@Jinksi
Copy link
Member

Jinksi commented Nov 11, 2024

I've proposed the required changes to Testing-instructions-for-critical-flows.md critical flows in this gist:

https://gist.github.com/Jinksi/56c54e75f25f6a118bfd365d8fe69743

Please review the code diff or rich/visual diff.

@Jinksi
Copy link
Member

Jinksi commented Nov 11, 2024

Note: back to in-progress – need to update screenshots.

@Jinksi
Copy link
Member

Jinksi commented Nov 11, 2024

Rather than regenerate all of the impacted screenshots (a siginificant portion of the 109 images), I've added the following notice to the critical flows:

Image

@Jinksi
Copy link
Member

Jinksi commented Nov 11, 2024

Ready for review.

I've proposed the required changes to Testing-instructions-for-critical-flows.md critical flows in this gist:

https://gist.github.com/Jinksi/56c54e75f25f6a118bfd365d8fe69743

Please review the code diff or rich/visual diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: deposits
Projects
None yet
Development

No branches or pull requests

2 participants