Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update xml2js to 0.5.0 #1330

Merged
merged 1 commit into from
May 1, 2023
Merged

chore(deps): Update xml2js to 0.5.0 #1330

merged 1 commit into from
May 1, 2023

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Apr 11, 2023

Description

This fixes CVE-2023-0842, which is of high severity

Ref: GHSA-776f-qx25-q3cc

It seems like there are no breaking changes in the code.

Steps to Test

  1. Export the database from your test site.
  2. Apply the patch. Don't forget to run npm ci.
  3. Run vip @<env> import SQL <file>
  4. Make sure everything works.

@sjinks sjinks self-assigned this Apr 11, 2023
@sjinks
Copy link
Member Author

sjinks commented Apr 11, 2023

Note to self: xml2js does not look maintained; it makes sense to look at fast-xml-parser

@sjinks
Copy link
Member Author

sjinks commented Apr 11, 2023

@sjinks sjinks marked this pull request as ready for review April 11, 2023 12:04
@sjinks sjinks force-pushed the update/xml2js branch 3 times, most recently from 069dc82 to b6aa444 Compare April 20, 2023 23:38
@sjinks sjinks merged commit 3b0f357 into develop May 1, 2023
@sjinks sjinks deleted the update/xml2js branch May 1, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants