Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Accept-Language header #399

Closed
pinarol opened this issue Sep 11, 2024 · 1 comment
Closed

Send Accept-Language header #399

pinarol opened this issue Sep 11, 2024 · 1 comment
Assignees
@andrewdmontgomery
Labels
enhancement New feature or request
Milestone
Milestone 4 - Qui...

Comments

@pinarol
Copy link
Contributor

pinarol commented Sep 11, 2024

We should send Accept-Language header in the REST API calls like:

Accept-Language: en-US, fr-CA, es-ES

It seems to me like we can take the values from NSLocale.preferredLanguages.
@pinarol pinarol added the enhancement New feature or request label Sep 11, 2024
@pinarol pinarol added this to the Milestone 4 - Quick Editor milestone Sep 11, 2024
@andrewdmontgomery andrewdmontgomery self-assigned this Sep 18, 2024
This was referenced Sep 19, 2024
Closed
Closed
@andrewdmontgomery
Copy link
Contributor

After investigating, it looks like a simple version of that header is already included by default. PR #416 adds a more comprehensive version of this header. See that PR for details.

@andrewdmontgomery andrewdmontgomery closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewdmontgomery andrewdmontgomery

Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone 4 - Quick Editor
2 participants
@andrewdmontgomery @pinarol