Skip to content

Commit 1937fa4

Browse files
authoredOct 5, 2024··
#442 Update Checkstyle version used by CodeClimate (#444)
* #442 Update Checkstyle version used by CodeClimate * Move channel declaration
1 parent d8ce793 commit 1937fa4

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed
 

‎.checkstyle.xml

+6-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
55
<!--
66
In order to be compatible with CodeClimate, we have to stay in sync with the version of Checkstyle that they are using.
7-
This is currently: 8.39. Check the links below to get up-to-date version information.
7+
It doesn't seem to be updated much by default, but we can specify a channel, which is currently using 10.7.0.
8+
Check the links below to get up-to-date version information.
9+
https://github.com/codeclimate/codeclimate-checkstyle/branches/all (channel/ branches)
810
https://docs.codeclimate.com/docs/checkstyle
911
https://github.com/codeclimate/codeclimate-checkstyle/blob/master/bin/install-checkstyle.sh
1012
-->
@@ -117,7 +119,7 @@
117119
<module name="UnnecessarySemicolonAfterTypeMemberDeclaration" />
118120
<module name="UnnecessarySemicolonInEnumeration" />
119121
<module name="UnnecessarySemicolonInTryWithResources" />
120-
<!-- Checkstyle 9.3: <module name="UnusedLocalVariable" /> -->
122+
<module name="UnusedLocalVariable" />
121123
<module name="VariableDeclarationUsageDistance" />
122124

123125
<!-- Headers -->
@@ -136,7 +138,7 @@
136138
<module name="JavadocBlockTagLocation" />
137139
<module name="JavadocContentLocation" />
138140
<module name="JavadocMethod">
139-
<property name="scope" value="package" />
141+
<property name="accessModifiers" value="package" />
140142
<property name="tokens" value="METHOD_DEF, ANNOTATION_FIELD_DEF" />
141143
</module>
142144
<module name="JavadocMissingLeadingAsterisk" />
@@ -236,7 +238,7 @@
236238
<!-- Override to exclude ELLIPSIS and to add METHOD_REF -->
237239
<property name="tokens" value="COMMA, SEMI, POST_INC, POST_DEC, LABELED_STAT, METHOD_REF" />
238240
</module>
239-
<!-- Checkstyle 8.45: <module name="NoWhitespaceBeforeCaseDefaultColon" /> -->
241+
<module name="NoWhitespaceBeforeCaseDefaultColon" />
240242
<module name="OperatorWrap" />
241243
<module name="ParenPad" />
242244
<module name="SeparatorWrap">

‎.codeclimate.yml

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ version: '2' # required to adjust maintainability checks
33
plugins:
44
checkstyle:
55
enabled: true
6+
channel: 'checkstyle-10-7-0'
67
config:
78
file: '.checkstyle.xml'
89

‎.idea/checkstyle-idea.xml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.