feat(advanced_lsp): signature help pop up added to AstroLSP

Author: mehalter

.typos.toml

@@ -1,3 +1,4 @@
 # See https://github.com/crate-ci/typos/blob/master/docs/reference.md to configure typos
 [default.extend-words]
 fo = "fo"
+noice = "noice"

src/content/docs/recipes/advanced_lsp.mdx

@@ -711,108 +711,15 @@ return {
 
 ## Automatic Signature Help
 
-:::tip
-
-This is available in the [AstroCommunity](https://github.com/AstroNvim/astrocommunity/tree/main/lua/astrocommunity/recipes/astrolsp-auto-signature-help)
-
-```lua title="lua/community.lua" ins={3}
-return {
-  "AstroNvim/astrocommunity",
-  { import = "astrocommunity.recipes.astrolsp-auto-signature-help" },
-}
-```
-
-:::
-
-Some users may want to have automatic pop ups of function signatures while editing with a language server. Using a combination of AstroCore and AstroLSP we can build a robust system for managing the signature help and automatically triggering it when necessary. Here is an in depth example:
+Some users may want to have automatic pop ups of function signatures while editing with a language server similar to that of functionality provided by [`noice.nvim`](https://github.com/folke/noice.nvim) and [`lsp_signature.nvim`](https://github.com/ray-x/lsp_signature.nvim). By default this behavior is disabled, but can easily be enabled by modifying `features.signature_help` in the AstroLSP `opts`:
 
 ```lua title="lua/plugins/signature_help.lua"
 return {
   "AstroNvim/astrolsp",
-  specs = {
-    {
-      "AstroNvim/astrocore",
-      ---@type AstroCoreOpts
-      opts = {
-        autocmds = {
-          signature_help_triggers = {
-            {
-              event = "LspAttach",
-              desc = "Add signature help triggers as language servers attach",
-              callback = function(args)
-                local client = vim.lsp.get_client_by_id(args.data.client_id)
-                if
-                  client and client.supports_method("textDocument/signatureHelp")
-                then
-                  vim.b[args.buf].signature_help_trigger =
-                    require("astrocore").list_insert_unique(
-                      vim.b[args.buf].signature_help_trigger,
-                      client.server_capabilities.signatureHelpProvider.triggerCharacters
-                        or {}
-                    )
-                end
-              end,
-            },
-            {
-              event = "LspDetach",
-              desc = "Safely remove LSP signature help triggers when language servers detach",
-              callback = vim.schedule_wrap(function(args)
-                if not vim.api.nvim_buf_is_valid(args.buf) then
-                  return
-                end
-                local signature_help_trigger = {}
-                for _, client in
-                  pairs(
-                    (vim.lsp.get_clients or vim.lsp.get_active_clients)({
-                      bufnr = args.buf,
-                    })
-                  )
-                do
-                  if
-                    client.id ~= args.data.client_id
-                    and client.supports_method("textDocument/signatureHelp")
-                  then
-                    require("astrocore").list_insert_unique(
-                      signature_help_trigger,
-                      client.server_capabilities.signatureHelpProvider.triggerCharacters
-                        or {}
-                    )
-                  end
-                end
-                vim.b[args.buf].signature_help_trigger = signature_help_trigger
-              end),
-            },
-          },
-        },
-      },
-    },
-  },
   ---@type AstroLSPOpts
   opts = {
-    autocmds = {
-      auto_signature_help = {
-        cond = "textDocument/signatureHelp",
-        {
-          event = "TextChangedI",
-          desc = "Automatically trigger signature help when a trigger character is typed",
-          callback = function(args)
-            local signature_help_trigger =
-              vim.b[args.buf].signature_help_trigger
-            if signature_help_trigger then
-              local cur_line = vim.api.nvim_get_current_line():gsub("%s+$", "") -- rm trailing spaces
-              local pos = vim.api.nvim_win_get_cursor(0)[2]
-              local cur_char = cur_line:sub(pos, pos)
-
-              for _, char in ipairs(signature_help_trigger) do
-                if cur_char == char then
-                  vim.lsp.buf.signature_help()
-                  return
-                end
-              end
-            end
-          end,
-        },
-      },
+    features = {
+      signature_help = true, -- enable automatic signature help popup globally on startup
     },
   },
 }