-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(stylesheet): make everything more consistent #23
Conversation
Thanks! I like the changes:
but I would prefer not to have:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This looks good to me % one comment below:
src/style.css
Outdated
+0px 0px 15px var(--bg-color), | ||
+0px -15px 20px rgba(255,0,0,0.5), | ||
-15px +10px 20px rgba(0,255,0,0.5), | ||
+10px +15px 20px rgba(0,0,255,0.5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reverse this change? It looks like you used indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I indented it like that so the px is on the same column but I'll fix it in a sec 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also shouldn't this have some transition property because it's a :hover element? I have to hover for a few seconds before it shows up, very cool effect though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transition is:
transition: text-shadow 1s ease-in-out 1s;
So, we wait for 1 second before triggering the transition. This was done on purpose to make this a bit harder to find. This is a sort of easter eggs.
Thanks! |
changes:
:
)white
&black
with#fff
and#000
(shorter)