fix: resolve issue preventing correct access to closure variables

Author: jacopodl

argon/lang/compiler2/compiler2.cpp

@@ -65,10 +65,12 @@ SymbolT *Compiler::IdentifierLookupOrCreate(String *id, argon::lang::compiler2::
 
     auto *sym = this->unit_->symt->SymbolLookup(id, false);
     if (sym == nullptr) {
-        if ((sym = this->unit_->symt->SymbolInsert(id, type)) == nullptr)
+        auto freevar = this->unit_->IsFreeVar(id);
+
+        if ((sym = this->unit_->symt->SymbolInsert(id, type, freevar)) == nullptr)
             throw DatatypeException();
 
-        if (this->unit_->IsFreeVar(id)) {
+        if (freevar) {
             dst = this->unit_->enclosed;
             sym->free = true;
         }

argon/lang/compiler2/symt.cpp

@@ -108,11 +108,11 @@ bool SymbolT::NewNestedTable() {
     return true;
 }
 
-SymbolT *SymbolT::SymbolInsert(String *s_name, SymbolType s_type) {
+SymbolT *SymbolT::SymbolInsert(String *s_name, SymbolType s_type, bool freevar) {
     SymbolT *sym = SymbolLookup(s_name, true);
     SymbolT *target = this;
 
-    if (this->stack != nullptr)
+    if (!freevar && this->stack != nullptr)
         target = this->stack;
 
     if (sym != nullptr) {

argon/lang/compiler2/symt.h

@@ -62,7 +62,11 @@ namespace argon::lang::compiler2 {
 
         bool NewNestedTable();
 
-        SymbolT *SymbolInsert(vm::datatype::String *s_name, SymbolType s_type);
+        SymbolT *SymbolInsert(vm::datatype::String *s_name, SymbolType s_type, bool freevar);
+
+        inline SymbolT *SymbolInsert(vm::datatype::String *s_name, SymbolType s_type) {
+            return SymbolInsert(s_name, s_type, false);
+        }
 
         SymbolT *SymbolLookup(const vm::datatype::String *s_name, bool local) const;
     };