fix: contract_type cache corruption #2540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
changed the title
bitwise-constructs
approved these changes
Mar 7, 2025
|
I'd like a test for this before calling it good, but I am happy to write such test. |
antazoey
reviewed
Mar 8, 2025
| address, contract_type=contract_type | ||
| ) | ||
| # Store contract_type in cache only if missing | ||
| if (contract := self.chain_manager.contracts.instance_at(address)) is None: |
There was a problem hiding this comment.
I don't think instance_at() returns None, you probably want .get_contract_type() here.
Suggested change
| if (contract := self.chain_manager.contracts.instance_at(address)) is None: | |
| if (contract_type := self.chain_manager.contracts.get_contract_type(address)) is None: |
If you have a test in mind, please do! I am traveling today but can get back to the workstation to pick up this (and other) changes on Monday morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2539