Fix using unavailable worker cached in client-pool to resolve #18693 #18694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. |
|
Thanks for your pr! But are your sure you want to submit to main branch? If you want to fix the 2.x issue, please submit to master-2.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
to fix #18693
Why are the changes needed?
In ClientPool, ClientPoolKey only takes ip into consideration, which is not enough, it can cause incorrect worker cache in clientPool. To fix the problem, hostName should be taken into consideration to compare ClientPoolKey as well
Does this PR introduce any user facing changes?
No