Group permissions lost then moving node to another Site

[iohann95]

If you attempt to move a node from one site to another, all defined group permissions are lost. This occurs because Alfresco wants to clear Site Groups from the old site, but in doing so, it inadvertently removes all group permissions:

alfresco-community-repo/repository/src/main/java/org/alfresco/repo/site/SitesPermissionCleaner.java

Line 136 in 9297fa5

if (authority.startsWith(PermissionService.GROUP_PREFIX) &&

This issue can be resolved by modifying the code to:

if (authority.startsWith(PermissionService.GROUP_PREFIX + "site_") &&

This adjustment ensures that only "site groups" are removed, preserving explicitly defined ones.

Thanks to MorganP at the Alfresco Discord for pointing me to the right direction.

[morgan-patou]

@iohann95 : No problems.

Note for @anyone that will take this case, it probably needs to not hardcode the "site_" reference:

• GROUP_PREFIX comes from PermissionService
• SITE_PREFIX is defined inside SiteServiceImpl
• Alternatively, GROUP_SITE_PREFIX is already defined insite SiteServiceImpl, and this would be what needs to be used from my point of view.

I don't have time to make a PR at the moment (and test/validate it) but I believe "GROUP_SITE_PREFIX" should be used here.