Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make invalid MSVC version a fatal error #136

Open
hawkinsw opened this issue Jun 13, 2023 · 0 comments
Open

Make invalid MSVC version a fatal error #136

hawkinsw opened this issue Jun 13, 2023 · 0 comments

Comments

@hawkinsw
Copy link
Collaborator

bpf_conformance/src/CMakeLists.txt

Line 22 in 8421a6b

message("ERROR: Unsupported Visual Studio version")

I was just wondering whether you would be okay making CMake's inability to determine MSVC's version a fatal error? As I was configuring for Windows, it caught me out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hawkinsw