[BUG] Firing at ammo crates and NPCs causes a crash?

[Xer0n]

Short Description

When firing at ammo crates, ACF will error and cause a server crash.
Seems to be any type of HE rounds that cause it.

Branch and Version

Latest master branch of ACF-3, ACF Missiles, Contraption Framework and Cluster Munitions.

Console Error Logs (Optional)

Lua Stack:
[C][+0] [C] in GetMesh
[L][+1] addons/acf-3/lua/acf/damage/explosion_sv.lua:51 in field getRandomPos Line 37 -> 71
[L][+2] addons/acf-3/lua/acf/damage/explosion_sv.lua:136 in field createExplosion Line 81 -> 234
[L][+3] addons/acf-3/lua/acf/entities/ammo_types/aphe.lua:133 in method OnFlightEnd Line 121 -> 136
[L][+4] addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:201 in field OnImpact Line 176 -> 203
[L][+5] addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:295 in field DoBulletsFlight Line 217 -> 298
[L][+6] addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:85 in field CalcBulletFlight Line 66 -> 92
[L][+7] addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:115 in field fn Line 112 -> 118
[L][+8] addons/ulib/lua/ulib/shared/hook.lua:109 in field Run Line 92 -> 150
[L][+9] addons/acf-3/lua/acf/core/utilities/clock/clock.lua:13 in field fn Line 6 -> 14
[L][+10] addons/ulib/lua/ulib/shared/hook.lua:109 in anonymous function Line 92 -> 150

---

Lua Stack:
[C][+0] [C] in TraceLine
[L][+1] addons/acf-3/lua/acf/core/utilities/traces_sh.lua:57 in field trace Line 51 -> 81
[L][+2] addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:246 in field DoBulletsFlight Line 217 -> 298
[L][+3] addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:288 in field DoBulletsFlight Line 217 -> 298

+898 Lines of the same output.

How to Reproduce (Optional)

Player was firing at NPC's and Ammo Crates with HE which causes server crash.

Screenshots (Optional)

If applicable, add screenshots to help explain your problem.

Additional Information (Optional)

Add any other information about the problem you think might help find the issue.

[thecraftianman]

What NPCs in particular were you firing at?

[edshot99]

Had the same problem and went through the cumbersome task of trying every NPC to find that only the Dog and Strider NPC's cause server lockups printing this stack trace every couple of minutes or so while players eventually disconnect.

[[ACF] Armored Combat Framework] stack overflow
  1. __index - [C]:-1
   2. CheckClips - lua/acf/core/utilities/traces_sh.lua:15
    3. doRecursiveTrace - lua/acf/core/utilities/traces_sh.lua:42
     4. trace - lua/acf/core/utilities/traces_sh.lua:68
      5. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:247
       6. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
        7. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
         8. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
          9. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
           10. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
            11. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
             12. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
              13. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
               14. DoBulletsFlight - lua/acf/ballistics/ballistics_sv.lua:289
                15. DoBulletsFlight - lua

In addition, I find ammo bombing to cause unrecoverable server lockups more often than before, but this is just my experience.

[thecraftianman]

Should be fixed with this commit, but if it still isn't then just reopen the issue and I'll take another look.

[edshot99]

@thecraftianman
The bug is mostly fixed, but can still happen with the same NPCs on rare occasions except this time the server will be locked up with nothing being printed to console.

[HeinrichTeidt]

Issue is still happening, I went on singleplayer, first try my game locked up like before.