Hooks are not always checks, shall we update the hooks interface to reflect this? #26
Unanswered
auryn-macmillan
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The interface for hooks describes the pre and post execution calls as "checks",
preCheck
andpostCheck
.This is descriptive of how guards have been used historically and how many hooks will presumably be used in future. However, it's perhaps too limiting of a descriptor as some use-cases will not be checks, per se, but additional code that must be executed alongside each transaction. This is presumably the rationale for changing the name from "guard" to "hook", so it stands to reason that the rest of the interface should reflect this as well.
I'd propose something like the following changes.
Beta Was this translation helpful? Give feedback.
All reactions