Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(KtField*): introduce data-test prop to substitute when there is formKey="NONE" #620

Open
carsoli opened this issue Apr 22, 2022 · 0 comments
Labels
priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs

Comments

@carsoli
Copy link
Contributor

carsoli commented Apr 22, 2022

  • If FormKey is none, the data-test that's auto-generated becomes formId="" + any controller object/list formKey but the None is an empty string equivalent

Problem:
when we add data-test to manually identify the field with formKey none, the key is added to the wrapper and not the input

Ideally, we should not have to rewrite the data-test from scratch
so maybe we need a fieldId that we bind IFF the formKey is none and can't be used

Needs to be done on all fields

@carsoli carsoli added the priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs
Projects
None yet
Development

No branches or pull requests

1 participant