Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KtBreadcrumb: Remove or Simplify Separator #510

Open
FlorianWendelborn opened this issue Sep 22, 2021 · 1 comment
Open

KtBreadcrumb: Remove or Simplify Separator #510

FlorianWendelborn opened this issue Sep 22, 2021 · 1 comment
Labels
package:kotti-ui @3yourmind/kotti-ui priority:2-low Should be fixed in the next year type:chore chore, cleanup, removal of dead-code, etc.

Comments

@FlorianWendelborn
Copy link
Member

Current way is overkill, and the need for it is unclear.

(Via #504 (comment))

@FlorianWendelborn FlorianWendelborn added priority:2-low Should be fixed in the next year package:kotti-ui @3yourmind/kotti-ui type:chore chore, cleanup, removal of dead-code, etc. labels Sep 22, 2021
@Isokaeder
Copy link
Collaborator

Isokaeder commented Oct 6, 2021

In general we either want a slash / or yoco's CHEVRON_RIGHT icon. If we only want one, I would personally favor CHEVRON_RIGHT. So we can either always use that or at least use an enum like this as prop instead of current madness:

enum Separator {
  SLASH, CHEVRON_RIGHT
}

Personally would choose Occam's Razor aprroach and just use CHEVRON_RIGHT though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui priority:2-low Should be fixed in the next year type:chore chore, cleanup, removal of dead-code, etc.
Projects
None yet
Development

No branches or pull requests

2 participants