Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GST Calculator #304

Closed
wants to merge 19 commits into from
Closed

GST Calculator #304

wants to merge 19 commits into from

Conversation

BabyElias
Copy link

Description 📜

Added a GST Calculator
Fixes #269

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GSSOC'22 contributor

Screenshots / Gif (Optional) 📸

imagee

@awesome-bot-app
Copy link


Thanks for opening the pull request @BabyElias! I will look into it ASAP!
Till then you can improve your code & you can show your love by staring my repos 😋.

mansi-garg-12
mansi-garg-12 requested changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove binary files(.jpg and .png)

@mansi-garg-12 mansi-garg-12 added changes Changes Requested and removed review_needed labels May 11, 2022
@BabyElias
Copy link
Author

@mansi-garg-12 Removed the files

mansi-garg-12
mansi-garg-12 requested changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Please check your code for phone and tablet from right hand side.
And enhance the UI / UX of your project.

@BabyElias
Copy link
Author

@mansi-garg-12 In order to improve the UI I would need to add binary files to my contribution. Should I?

@BabyElias
Copy link
Author

New Layout & Responsiveness Check
image

mansi-garg-12
mansi-garg-12 requested changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
check your code your button is not working showing some errors.

@BabyElias
Copy link
Author

@mansi-garg-12 The output will be visible only for valid GST Tax slabs i.e 5,12,18 & 28%
image

@BabyElias
Copy link
Author

@mansi-garg-12 Please review if any changes are needed

mansi-garg-12
mansi-garg-12 requested changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please integrate your all CSS files.

@BabyElias
Copy link
Author

@mansi-garg-12 I am unable to integrate the Bootstrap CSS in my main CSS.

@mansi-garg-12
Copy link
Collaborator

just put all all your CSS code in single files and you may chk youtube video .

0xvashishth
0xvashishth requested changes May 28, 2022
View reviewed changes
Copy link
Owner

@0xvashishth 0xvashishth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to include only three files :)
index.html, script.js, style.css

Please remove all the min.css files as you can use the cdn !

@BabyElias BabyElias closed this by deleting the head repository Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansi-garg-12 mansi-garg-12 mansi-garg-12 requested changes

@0xvashishth 0xvashishth 0xvashishth requested changes

Assignees
No one assigned
Labels
changes Changes Requested GSSoC22
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GST Calculator
3 participants
@BabyElias @mansi-garg-12 @0xvashishth